-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: BROS-128: Fix large data multichannel displaying #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hey @Gondragos tested your changes and this fixes the timeline issue I identified as well. with this we can also close off this and you can close my PR here (because your fix is better because it keeps your optimisations) Great stuff 🥳 |
Hey @Gondragos ! I found an issue with the y-axis scaling when Root cause: Fixed by:
The y-axis now properly scales to show tight ranges around visible data when zooming with You can cherry pick my commit fb-BROS-128/ts-mc-uod...cloudmark:label-studio:fb-BROS-128/ts-mc-uod or I can open a PR which goes to your branch |
This pull request fixes the handling of a large amount of data by
TimeSeriesVisualizer
.Previously the same logic existed in the
ChannelD3
. And it was transferred to the new component with some changes for providing supporting MultiChannel mode of displaying. However, there were inaccuracies during the transfer and here are the fixes.Before
After